Orchestration spec update 12a - Tests #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 9, 2025 14:08
…ation-spec-update-12a-tests
…update-12a' into orchestration-spec-update-12a-tests
rpanackal
changed the title
rpanackal
commented
Jan 9, 2025
Comment on lines
+5
to
+19
| { | ||
| "role": "system", | ||
| "content": "You are a multi language translator" | ||
| }, | ||
| { | ||
| "role": "user", | ||
| "content": "Reply with 'Orchestration Service is working!' in German" | ||
| }, | ||
| { | ||
| "role": "assistant", | ||
| "content": "Orchestration Service funktioniert!" | ||
| }, | ||
| { | ||
| "role": "user", | ||
| "content": "How about in French?" |
There was a problem hiding this comment.
Just added a few more items for different roles in templating to increase the test coverage.
newtork
reviewed
Jan 9, 2025
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 9, 2025
orchestration/src/test/resources/__files/multiChatMessageResponse.json
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 9, 2025
newtork
reviewed
Jan 9, 2025
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
approved these changes
Jan 10, 2025
rpanackal
added a commit
that referenced
this pull request
Jan 14, 2025
* updated orchestration.yaml * regenerated model after spec update * Minimal integration of new features - convenience api does not support MultiChatMessage * Fix deserialization with custom addition - try-catch based approach on Subtype annotation mentions - Also pass custom list of candidates * Fix deserialization with custom addition - try-catch based approach on Subtype annotation mentions - Also pass custom list of candidates * Fix codestyle * release notes for spec update * Update release_notes.md remove version naming * Follow-up update on release_notes.md * update of release_notes.md implementing review feedback * Update docs/release-notes/release_notes.md Co-authored-by: Alexander Dümont <22489773+newtork@users.noreply.github.com> * Orchestration spec update 12a - Tests (#269) * Test - improve coverage on existing tests in addition - tests for failure cases of PolymorphicFallbackDeserializer * Unit test request with image (low level api) * Test calling multi chat response using convenience * minor test method name change * Replace url with a sample --------- Co-authored-by: Roshin Rajan Panackal <roshin.rajan.panackal@sap.com> * Improve PolymorphicFallbackDeserializer - Generalize test case - add @SInCE and @beta annotation on custom deserializer (public) * lombok on PolymorphicFallbackDeserializer * make PolymorphicFallbackDeserializer AllArgsConstructor protected and use chaining * Add Beta annotation, modify access on deserializer, improve test - make PolymorphicFallbackDeserializer AllArgsConstructor protected and use chaining - Add beta annotation to MultiChatMessageContent and ChatMessagesInner - move request body constraint to stub * Revert @beta annotation (manual) addition on interfaces * Revert stub change --------- Co-authored-by: I750911 <till.kurek@sap.com> Co-authored-by: Roshin Rajan Panackal <roshin.rajan.panackal@sap.com> Co-authored-by: Alexander Dümont <22489773+newtork@users.noreply.github.com> Co-authored-by: Roshin Rajan Panackal <36329474+rpanackal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#135.
Add all necessary test for new Orchestration update (12a)
Feature scope:
PolymorphicFallbackDeserializerfor failure caseMultiChatMessageobjectsMessage(convenience) type objects.Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated