Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requireNonNull #24

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Remove requireNonNull #24

merged 2 commits into from
Aug 15, 2024

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Aug 15, 2024

Context

AI/ai-sdk-java-backlog#53.

Follow up of #4, especially: Fix return type @Nonnull / @Nullable annotation.
Now that the return type is @Nonnull, we can remove requireNonNull.

Feature scope:

  • Remove requireNonNull

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@MatKuhr MatKuhr merged commit 53b5aa9 into main Aug 15, 2024
5 checks passed
@MatKuhr MatKuhr deleted the nullable-removal branch August 15, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants