Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Using Orchestration Grounding module #228
Test: Using Orchestration Grounding module #228
Changes from 11 commits
07c621f
b20488f
7c14547
a3a40fb
3728cf9
72d1132
e21f205
353525c
ee5458c
7f70a46
3b0d49c
b5bd89d
8fa4e96
03877b1
27d8eb7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Minor/Comment)
I think AssertJ also has
).hasToString(
as replacement for.toString()).isEqualTo(
.Do we actually need the string check when we compare the values anyway? AFAIK we didn't do this in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot compare the values directly here, as
getModuleResults().getGrounding().getData()
returns anObject
so that I cannot access "grounding_query" or "grounding_result" via the generated code. This is why I compare it as a String.Also, I use
.toString()).startsWith(...
now to not need to provide the complete rather long expected String.If you feel there is a better way to do that, please let me know :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object
is somewhat misleading, actually this will always be aMap<String, Object>
. (Ideally, our generator would be improved in that regard).So you could cast to that and use
.get("grounding_query")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casting this adds a warning, though. Is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's just a test assertion, so it's okay if this ever fails (which would mean we've changed our generator but didn't update tests)