Merge pull request #607 from SAML-Toolkits/php84_fix_test_warnings

Php84 fix test warnings
SAML-Toolkits · Jan 13, 2025 · 76236a6 · 76236a6
2 parents cace752 + 7516681
commit 76236a6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 34 deletions.
diff --git a/.coveralls.yml b/.coveralls.yml
@@ -1,6 +1,6 @@
-service_name: travis-ci
+service_name: github
 
-src_dir: lib
+src_dir: src
 
 coverage_clover: tests/build/logs/clover.xml
 

diff --git a/.travis.yml b/.travis.yml
diff --git a/tests/src/OneLogin/Saml2/ResponseTest.php b/tests/src/OneLogin/Saml2/ResponseTest.php
@@ -1607,10 +1607,12 @@ public function testIsInValidCert()
 
         $response = new Response($settings, $xml);
 
-        $this->assertFalse($response->isValid());
+        $this->assertFalse(@$response->isValid());
+
         $possibleErrors = [
           "openssl_x509_read(): supplied parameter cannot be coerced into an X509 certificate!",
-          "openssl_x509_read(): X.509 Certificate cannot be retrieved"
+          "openssl_x509_read(): X.509 Certificate cannot be retrieved",
+          "Unable to extract public key"
         ];
         $this->assertTrue(in_array($response->getError(), $possibleErrors));
     }

diff --git a/tests/src/OneLogin/Saml2/SettingsTest.php b/tests/src/OneLogin/Saml2/SettingsTest.php
@@ -271,7 +271,7 @@ public function testThatOnlyBooleansCanBeUsedForCompressionSettings($invalidValu
         $this->assertTrue($responsesIsInvalid);
     }
 
-    public function invalidCompressSettingsProvider()
+    static public function invalidCompressSettingsProvider()
     {
         return array(
             array(1),
@@ -539,7 +539,7 @@ public function testGetSPMetadataWithX509CertNew($alwaysIncludeEncryption, $want
         $this->assertEquals($expectEncryptionKeyDescriptor ? 2 : 0, substr_count($metadata, '<md:KeyDescriptor use="encryption"'));
     }
 
-    public function getSPMetadataWithX509CertNewDataProvider()
+    static public function getSPMetadataWithX509CertNewDataProvider()
     {
         return [
             'settings do not require encryption' => [