Cleanup PR to emv contactless to contact bridge #2726
+362
−609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working demo works seems to work so far more cleanup and works working copy working, clean one more pass cleanup continues back in buisness babyyy final cleanup before PR I hope
|
You are welcome to add an entry to the CHANGELOG.md as well |
n-hutton
commented
Jan 21, 2025
| @@ -42,5 +43,6 @@ | |||
| #define AUTHKEYNONE 0xff | |||
|
|
|||
| void Mifare1ksim(uint16_t flags, uint8_t exitAfterNReads, uint8_t *uid, uint16_t atqa, uint8_t sak); | |||
| bool MifareSimInit(uint16_t flags, uint8_t *uid, uint16_t atqa, uint8_t sak, tag_response_info_t **responses, uint32_t *cuid, uint8_t *uid_len, uint8_t **rats, uint8_t *rats_len); | |||
There was a problem hiding this comment.
to avoid code replication, we use the mifare sim init code for evmsim - this means the flags are also set differently in cmdemv.c
n-hutton
commented
Jan 21, 2025
| @@ -670,7 +670,7 @@ static int CmdEMVSmartToNFC(const char *Cmd) { | |||
|
|
|||
| CLIParserFree(ctx); | |||
|
|
|||
| // todo: check this is relevant for us. | |||
| // todo for PR: check this is relevant for us. | |||
| SetAPDULogging(show_apdu); | |||
There was a problem hiding this comment.
what does SetAPDULogging do?
There was a problem hiding this comment.
it shows the tx/rx of apdu messages
n-hutton
commented
Jan 21, 2025
| @@ -490,6 +490,15 @@ ISO 7816-4 Basic interindustry commands. For command APDU's. | |||
| #define ISO7816_GET_CHALLENGE 0x84 | |||
| #define ISO7816_MANAGE_CHANNEL 0x70 | |||
|
|
|||
| #define ISO7816_APPLICATION_BLOCK 0x1E | |||
There was a problem hiding this comment.
these appeared to be missing..?
|
Let me know when you think its ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pr #2652 could do with some cleanup - this is one step towards that.
Lots more comments, separates things out a lot more cleanly, removes dead code, and so on.