Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Fix truncation bugs in replay() and ReplaySubject/Processor #6602

Merged
merged 1 commit into from
Jul 30, 2019
Merged

2.x: Fix truncation bugs in replay() and ReplaySubject/Processor #6602

merged 1 commit into from
Jul 30, 2019

Conversation

akarnokd
Copy link
Member

This PR fixes several truncation bugs with the time and size-bound replay() operators and their hot class versions:

  • Unexpected removal of the last item just added due to becoming out-of-date at the lowest time resolution, creating a hole in the linked chain and hanging the consumer. Related failure.
  • Incorrect size accounting upon removing old entries leading to more items dropped than expected.

Related: #6582

@akarnokd akarnokd merged commit a0290b0 into ReactiveX:2.x Jul 30, 2019
@akarnokd akarnokd deleted the ReplayTruncationFix2x branch July 30, 2019 10:47
This was referenced Aug 22, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
2.x Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @vanniktech