Merge pull request #228 from ReactiveBayes/fix_infer_dicttype

Fix missing check for infer function

src/inference.jl

@@ -1799,6 +1799,7 @@ function infer(;
     __infer_check_dicttype(:initmarginals, initmarginals)
     __infer_check_dicttype(:initmessages, initmessages)
     __infer_check_dicttype(:callbacks, callbacks)
+    __infer_check_dicttype(:data, data)
 
     if isnothing(autoupdates)
         __check_available_callbacks(warn, callbacks, available_callbacks(__inference))

test/inference_test.jl

@@ -1026,3 +1026,46 @@ end
 
     @test all(result.predictions[:y] .== Bernoulli(mean(Beta(1.0, 1.0))))
 end
+
+@testitem "Test misspecified types in infer function" begin
+    @model function rolling_die(n)
+        y = datavar(Vector{Float64}, n)
+
+        θ ~ Dirichlet(ones(6))
+        for i in 1:n
+            y[i] ~ Categorical(θ)
+        end
+    end
+
+    observations = [[1.0; zeros(5)], [zeros(5); 1.0]]
+
+    @testset "Test misspecified data" begin
+        @test_throws "Keyword argument `data` expects either `Dict` or `NamedTuple` as an input" infer(model = rolling_die(2), data = (y = observations))
+        result = infer(model = rolling_die(2), data = (y = observations,))
+        @test isequal(first(mean(result.posteriors[:θ])), last(mean(result.posteriors[:θ])))
+    end
+
+    @testset "Test misspecified initmarginals" begin
+        @test_throws "Keyword argument `initmarginals` expects either `Dict` or `NamedTuple` as an input" infer(
+            model = rolling_die(2), data = (y = observations,), initmarginals = (θ = Dirichlet(ones(6)))
+        )
+        result = infer(model = rolling_die(2), data = (y = observations,), initmarginals = (θ = Dirichlet(ones(6)),))
+        @test isequal(first(mean(result.posteriors[:θ])), last(mean(result.posteriors[:θ])))
+    end
+
+    @testset "Test misspecified initmessages" begin
+        @test_throws "Keyword argument `initmessages` expects either `Dict` or `NamedTuple` as an input" infer(
+            model = rolling_die(2), data = (y = observations,), initmessages = (θ = Dirichlet(ones(6)))
+        )
+        result = infer(model = rolling_die(2), data = (y = observations,), initmessages = (θ = Dirichlet(ones(6)),))
+        @test isequal(first(mean(result.posteriors[:θ])), last(mean(result.posteriors[:θ])))
+    end
+
+    @testset "Test misspecified callbacks" begin
+        @test_throws "Keyword argument `callbacks` expects either `Dict` or `NamedTuple` as an input" infer(
+            model = rolling_die(2), data = (y = observations,), callbacks = (before_model_creation = (args...) -> nothing)
+        )
+        result = infer(model = rolling_die(2), data = (y = observations,), callbacks = (before_model_creation = (args...) -> nothing,))
+        @test isequal(first(mean(result.posteriors[:θ])), last(mean(result.posteriors[:θ])))
+    end
+end