[CssSelectorBridge] Improvements (#3537) #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve parameter documentation / add tooltips * Allow extracting content from home page instead of article page * Keep titles from home page when every page <title> is the same
Pull request artifacts
|
|
@dvikan Thanks for reviewing my PR so fast 🙂 |
|
getting this |
@dvikan Managed to reproduce your issue. This happens when providing a selector to a DOM element that is not a link and does not contain any link. Fixing in #3585. |
dvikan
pushed a commit
that referenced
this pull request
Jul 31, 2023
When using parent element as URL selector: * If no <a> inside some elements, ignore them * If no <a> inside ALL elements, report an error Fixes #3573 #issuecomment-1656943318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #3457 including suggestions from #3537
Improve parameter documentation / add tooltips
Allow extracting content from home page instead of article page
Using site https://yohane.net/news/ as suggested by @antermin in #3537:
Home page:
Bridge parameters:
Resulting feed:
Feed is generated from home page using only one HTTP request to the website.
Keep titles from home page when every page <title> is the same
Now let's assume we want expanded content but each article page
<title>is the same:(First tab is home page, others are 3 first articles. Title is the same).
In that case, the bridge detects that each article
<title>is useless and keeps titles taken from links in home page:Bridge parameters:
Resulting feed:
Compatibility notes
Changes contained in this pull request should not affect compatibility of existing feeds. The only side effect I think of is that existing feeds targeting link parent element may now show some content while they previously did not.