[ImgurBridge] Web-scraping imgur bridge #1825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpangleLabs
changed the title
|
Taking a look at other PRs, namely #1836, I can see that yeah, fetching the page for every item in the feed is accepted practice. So I can add that later I think |
|
I think it's best to just close this, as #1662 or similar is going to be a better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a request for comment really. A start of what #1068 wants. Scrapes the website rather than using the API like #1662.
For filling in timestamp, content, and enclosures, it would need to request the page for each post in the feed, is this what we want? That seems rather heavy, are there other bridges that do this so I can understand our best practice around caching in that instance?
Alternatively on timestamps, imgur does say "4 hours ago" on the search page, and maybe I could parse that, but it would be messy, changing frequently.