Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTubeAPIBridge] New bridge based on the YouTube Data API #1272

Closed
wants to merge 6 commits into from

Conversation

fulmeek
Copy link
Contributor

@fulmeek fulmeek commented Aug 24, 2019

Hi there,

This is actually a port of my old YouTube feed based on the YouTube Data API v3 that I'm using since 2013. This either gets the latest videos or the activities feed of a channel.

The only downside is that it requires a valid YouTube Data API key in order to work. However, this is a one-time effort and not too complicated to get. There's a section in the configuration for this.

PS: This PR fixes the getConfig() method in the Configuration class as it throws a warning if no config is present for some reason (the array is not an array). That caused the BridgeImplementationTest to fail if you make use of it in your bridge. For such things, you should always prefer isset() or empty() over array_key_exists() as they are a language construct and not a function.

@Roliga
Copy link
Contributor

Roliga commented Aug 25, 2019

I'm curious what others think of the use of getConfig() in bridges. There are a few bridges already that'd benefit from per-bridge configuration. Perhaps a function like getConfig($key) could be implemented in BridgeAbstract to handle this in a more generic way.

@fulmeek
Copy link
Contributor Author

fulmeek commented Sep 15, 2019

Any news?

I'd like to make another PR for bridge specific configuration support as suggested by @Roliga afterwards.

@teromene
Copy link
Member

I think the main issue (#1170) is still open for discussion, and that we still need to discuss on the different ways to implement this.

@logmanoriginal
Copy link
Contributor

I'm going to stop here for today after shamelessly advertising my own attempt at a YouTubeAPIBridge from 2016: /~https://github.com/LogMANOriginal/rss-bridge/blob/YoutubeApiBridge/bridges/YoutubeApiBridge.php

@fulmeek Please see if you can leverage anything from it, especially the part about playlists.

I like where this is going, it's about time to add configuration support for bridges.

@fulmeek
Copy link
Contributor Author

fulmeek commented Oct 29, 2019

Playlist support indeed might be a nice addition. I'll see what I can do :)

@fulmeek fulmeek force-pushed the upstream-YouTubeAPIBridge branch from 6d41f3c to 9bc2be1 Compare November 13, 2019 21:37
@em92
Copy link
Contributor

em92 commented Mar 25, 2021

Hello, @fulmeek !
Teromene implemented options for private bridges. #1343
You can try that.

@dvikan
Copy link
Contributor

dvikan commented Mar 22, 2022

@fulmeek Is this PR still relevant?

@dvikan
Copy link
Contributor

dvikan commented Mar 29, 2022

No response from op. Changes to ./lib. This is a private kind of bridge that requires an api token which requires a youtube account. Maybe revisit this topic later.

@dvikan dvikan closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants