-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTubeAPIBridge] New bridge based on the YouTube Data API #1272
Conversation
I'm curious what others think of the use of |
Any news? I'd like to make another PR for bridge specific configuration support as suggested by @Roliga afterwards. |
I think the main issue (#1170) is still open for discussion, and that we still need to discuss on the different ways to implement this. |
I'm going to stop here for today after shamelessly advertising my own attempt at a YouTubeAPIBridge from 2016: /~https://github.com/LogMANOriginal/rss-bridge/blob/YoutubeApiBridge/bridges/YoutubeApiBridge.php @fulmeek Please see if you can leverage anything from it, especially the part about playlists. I like where this is going, it's about time to add configuration support for bridges. |
Playlist support indeed might be a nice addition. I'll see what I can do :) |
Changed complicated array_key_exists() construct to a straitforward isset() check to satisfy the same purpose without causing a warning if self::$config is missing for some reason.
6d41f3c
to
9bc2be1
Compare
@fulmeek Is this PR still relevant? |
No response from op. Changes to |
Hi there,
This is actually a port of my old YouTube feed based on the YouTube Data API v3 that I'm using since 2013. This either gets the latest videos or the activities feed of a channel.
The only downside is that it requires a valid YouTube Data API key in order to work. However, this is a one-time effort and not too complicated to get. There's a section in the configuration for this.
PS: This PR fixes the getConfig() method in the Configuration class as it throws a warning if no config is present for some reason (the array is not an array). That caused the BridgeImplementationTest to fail if you make use of it in your bridge. For such things, you should always prefer isset() or empty() over array_key_exists() as they are a language construct and not a function.