Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution in /~https://github.com/ROCm/rocBLAS/blob/develop/CMakeLists.txt stopped working in /~https://github.com/ROCm/hipTensor/pull/326/checks?check_run_id=35951788707
The reason is that rocm-cmake trys to extract the rocm version
ROCM_PLATFORM_VERSION
from variableROCM_DIR
.ROCM_DIR
is supposed to be something like/opt/rocm-6.3.3/
. But this is not mandatory. For example, in GFX942 CI pipeline, ROCM_DIR is '/agent/_work/1/rocm/share/rocm/cmake' (real path).So
ROCM_PLATFORM_VERSION
is not defined in GFX942 CI pipeline.The real goal of this ticket is to check if the compiler support
__hip_fp8_e5m2
and__hip_fp8_e4m3
.Created a cmake macro to check if the detected ROCm supports them.
The image below shows that cmake command fails with ROCm 6.2