Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimum ROCm version #326

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CongMa13
Copy link
Collaborator

@CongMa13 CongMa13 commented Jan 14, 2025

The solution in /~https://github.com/ROCm/rocBLAS/blob/develop/CMakeLists.txt stopped working in /~https://github.com/ROCm/hipTensor/pull/326/checks?check_run_id=35951788707

The reason is that rocm-cmake trys to extract the rocm version ROCM_PLATFORM_VERSION from variable ROCM_DIR.

ROCM_DIR is supposed to be something like /opt/rocm-6.3.3/. But this is not mandatory. For example, in GFX942 CI pipeline, ROCM_DIR is '/agent/_work/1/rocm/share/rocm/cmake' (real path).

So ROCM_PLATFORM_VERSION is not defined in GFX942 CI pipeline.


The real goal of this ticket is to check if the compiler support __hip_fp8_e5m2 and __hip_fp8_e4m3.

Created a cmake macro to check if the detected ROCm supports them.

The image below shows that cmake command fails with ROCm 6.2

image

@CongMa13 CongMa13 marked this pull request as ready for review January 14, 2025 16:59
cgmillette
cgmillette previously approved these changes Jan 20, 2025
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CongMa13 CongMa13 force-pushed the min_rocm_version branch 2 times, most recently from 3b53fcf to da00c69 Compare January 21, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants