Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pba-d-01-kw2x: remove duplicate MCPU #9921

Merged
merged 1 commit into from
Sep 11, 2018
Merged

pba-d-01-kw2x: remove duplicate MCPU #9921

merged 1 commit into from
Sep 11, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Sep 11, 2018

Contribution description

MCPU is already defined to CPU_ARCH which is cortex-m4.
Removing this line does not change the value:

make --no-print-directory -C examples/hello-world/ BOARD=pba-d-01-kw2x \
    info-debug-variable-CPU_ARCH info-debug-variable-MCPU
cortex-m4
cortex-m4

The board was the only board defining MCPU

git grep MCPU boards/                                                                                                                   
boards/pba-d-01-kw2x/Makefile.include:export MCPU = cortex-m4

Testing procedure

Run this command in master and this PR:

make --no-print-directory -C examples/hello-world/ BOARD=pba-d-01-kw2x \
        info-debug-variable-CPU_ARCH info-debug-variable-MCPU

You should get the same output

cortex-m4
cortex-m4

Issues/PRs references

Found while working in #9913

@cladmi
pba-d-01-kw2x: remove duplicate MCPU
99a0664 
MCPU is already defined to `CPU_ARCH` which is `cortex-m4`.
Removing this line does not change the value:

    make --no-print-directory -C examples/hello-world/ BOARD=pba-d-01-kw2x \
        info-debug-variable-CPU_ARCH info-debug-variable-MCPU
    cortex-m4
    cortex-m4
@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 11, 2018
@cladmi cladmi requested a review from aabadie September 11, 2018 13:44
jnohlgard
jnohlgard approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 11, 2018
@miri64
Copy link
Member

miri64 commented Sep 11, 2018

Murdock's compile test should suffice for this simple build system update.

@miri64 miri64 merged commit 66e33a4 into RIOT-OS:master Sep 11, 2018
@cladmi cladmi deleted the pr/cleanup/pba/mcpu branch September 12, 2018 10:28
@jia200x jia200x added this to the Release 2018.10 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
4 participants
@cladmi @miri64 @jnohlgard @jia200x