Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump poetry to 2.0.1 #2341

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Bump poetry to 2.0.1 #2341

merged 1 commit into from
Jan 20, 2025

Conversation

DanielNoord
Copy link
Member

Bump poetry and fix the deprecation warning about dev-dependencies.

@DanielNoord DanielNoord requested a review from staticdev January 18, 2025 11:58
@DanielNoord DanielNoord marked this pull request as ready for review January 18, 2025 11:59
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielNoord I would say the best solution is replcing poetry by uv. It is much faster.. I did it yesterday with staticdev/human-readable#712

What do you think?

@DanielNoord
Copy link
Member Author

I don't have a lot of trouble with poetry being slow in this repository.

This seems like an easy fix, replacing with a different tool seems to be more work and there are still lots of PRs to go through

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (90e2c73) to head (e3753af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2341   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          40       40           
  Lines        3098     3098           
  Branches      788      788           
=======================================
  Hits         3071     3071           
  Misses         15       15           
  Partials       12       12           

@DanielNoord DanielNoord requested a review from staticdev January 20, 2025 12:46
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we can merge it, actually it is a small effort to move to UV also in the future.

@staticdev staticdev merged commit c85b575 into main Jan 20, 2025
38 checks passed
@staticdev staticdev deleted the poetry-bump branch January 20, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants