-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ESLint with minimal config #2831
Conversation
JS File Size Changes (gzipped)A total of 5 files have changed, with a combined diff of -4 B (-0.1%).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think that's a good strategy, add minimal ESLint at first, then add rules gradually.
Btw at some point we should rewrite all these |
Guess I'll make a PR for the |
Welcome to the future, Prism.js! Glad to see this happening. |
I am envious of your energy! 😁 |
Motivation:
#1796 seems to have become stale because of disagreement over indentation style and the sheer number of changes (look at the number of conflicts).
Description:
This PR adds ESLint with a minimal config. This means that the ESLint config only contains checks for possible errors and best practices. It does not contain style rules.
The idea is to get ESLint now and add style rules later. That way, we can benefit from error checking now and can discuss the style we want to enforce in detail in dedicated PRs. Each dedicated PR will only add/change one rule (or a small number of rules), so we can move quickly and review each rule change individually.
Future PRs:
There are a few PRs I will make as soon as this one got merged:
Changes