Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL improvements for SDeMo #367

Merged
merged 15 commits into from
Feb 28, 2025
Merged

QoL improvements for SDeMo #367

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c020d6
feat(sdemo): todo notes
tpoisot Feb 26, 2025
67d70fb
feat(sdemo): todo note
tpoisot Feb 26, 2025
bdfa009
feat(sdemo): verbose option for variable selection
tpoisot Feb 27, 2025
f6e1dfc
semver(demo): v1.3.0
tpoisot Feb 27, 2025
173a11e
chore(demo): cleanup todo
tpoisot Feb 27, 2025
a876a0a
feat(sdemo): save the logistic models
tpoisot Feb 27, 2025
c4c12f9
bug(sdemo): verbose variable selection
tpoisot Feb 27, 2025
b9adc65
bug(demo): round takes a KEYWORD for digits
tpoisot Feb 27, 2025
1d9a0ae
bug(demo): test io
tpoisot Feb 27, 2025
da371fc
chore(demo): pipeline function
tpoisot Feb 27, 2025
9cf89fb
feat(demo): logistic output / validation
tpoisot Feb 27, 2025
c1a2423
doc(demo): Logistic
tpoisot Feb 27, 2025
726e824
bug(demo): lack of Logistic validation data not detected
tpoisot Feb 27, 2025
8ea5872
Merge branch 'main' into feat/sdemo/term
tpoisot Feb 27, 2025
81450b5
feat(demo): do not display the regularization part of the loss
tpoisot Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bug(sdemo): verbose variable selection
  • Loading branch information
@tpoisot
tpoisot committed Feb 27, 2025
commit c4c12f9079d1f3aca817d27378d941913a83a829
2 changes: 1 addition & 1 deletion SDeMo/src/variables/selection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function forwardselection!(
best_perf = mcc(noskill(model))
while ~isempty(on_top)
if verbose
nvar = lpad(length(candidates), 2, " ")
nvar = lpad(length(on_top), 2, " ")
@info "[$(nvar) vars.] MCC val. ≈ $(round(best_perf, 3))"
end
scores = zeros(length(on_top))
Expand Down