Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest wpilib!7609 and add turbo button #1662

Merged
merged 17 commits into from
Jan 11, 2025
Merged

Ingest wpilib!7609 and add turbo button #1662

merged 17 commits into from
Jan 11, 2025

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Dec 28, 2024 •
edited
Loading

Now that wpilibsuite/allwpilib#7572 and wpilibsuite/allwpilib#7609 have been merged:

  • Adds a magic hidden button to enable the new frame grabber behavior by adding a boolean topic at /photonvision/use_new_cscore_frametime. Toggle this to true to maybe increase FPS at the cost of latency variability
  • Bumps WPILib to ingest [cscore] Use frame time in Linux UsbCameraImpl wpilibsuite/allwpilib#7609 , but doesn't currently provide any user feedback about the time source. I don't think that reporting this super matters?

@mcm001 mcm001 requested a review from a team as a code owner December 28, 2024 20:17
@mcm001 mcm001 marked this pull request as draft December 28, 2024 20:18
@mcm001 mcm001 marked this pull request as ready for review December 30, 2024 00:43
@mcm001 mcm001 changed the title [draft] Use last frame time and JNI cscore Use last frame time and JNI cscore Dec 30, 2024
@mcm001 mcm001 changed the title Use last frame time and JNI cscore Ingest wpilib!7609 and add turbo button Jan 7, 2025
mcm001
mcm001 commented Jan 10, 2025
View reviewed changes
build.gradle Show resolved Hide resolved
spacey-sooty
spacey-sooty approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase then LGTM

@mcm001 mcm001 merged commit 83c124f into PhotonVision:main Jan 11, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bankst Bankst Bankst left review comments

@spacey-sooty spacey-sooty spacey-sooty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcm001 @Bankst @spacey-sooty