Test field map collection #927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
commented
Feb 26, 2025
| generate_bids_skeleton(str(bids_dir), dset_fmap_intendedfor_bidsuri) | ||
| layout = BIDSLayout(str(bids_dir)) | ||
| dwi_file = layout.get(suffix='dwi', extension='nii.gz', return_type='filename')[0] | ||
| fieldmaps = layout.get_fieldmap(dwi_file, return_list=True) |
There was a problem hiding this comment.
BIDSLayout.get_fieldmap doesn't work on BIDS URIs, so we need to either work around it like SDCFlows does or contribute to PyBIDS to make it work.
tsalo
commented
Feb 26, 2025
| generate_bids_skeleton(str(bids_dir), dset_fmap_b0fields) | ||
| layout = BIDSLayout(str(bids_dir)) | ||
| dwi_file = layout.get(suffix='dwi', extension='nii.gz', return_type='filename')[0] | ||
| fieldmaps = layout.get_fieldmap(dwi_file, return_list=True) |
There was a problem hiding this comment.
I don't expect this to work. We probably need custom code like SDCFlows uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Documentation that should be reviewed