chore(Notifications): Refactor notification settings to be per team #10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
commented
Feb 19, 2025
| })) | ||
| .onConflict((oc) => oc.doNothing()) | ||
| .execute() | ||
| if (service === 'msTeams' || service === 'mattermost') { |
There was a problem hiding this comment.
Previously we inserted this for most integrations, including GitLab and GCal 🤦
...server/postgres/migrations/2025-02-18T17:28:11.536Z_notificationSettingsPerTeamAndChannel.ts
Outdated
Show resolved
Hide resolved
yarn.lock
Outdated
| version "0.15.0" | ||
| resolved "https://registry.yarnpkg.com/kysely-codegen/-/kysely-codegen-0.15.0.tgz#771c0256c24897ea64d5713dc10e40e8a359b96b" | ||
| integrity sha512-LPta2nQOyoEPDQ3w/Gsplc+2iyZPAsGvtWoS21VzOB0NDQ0B38Xy1gS8WlbGef542Zdw2eLJHxekud9DzVdNRw== | ||
| kysely-codegen@^0.17.0: |
There was a problem hiding this comment.
Previous version would not generate the column type for SlackNotificationEventEnum[] correctly.
Dschoordsch
force-pushed
the
chore/10685/makeNotificationSettingsPerTeamAndChannel
branch
from
6c7e914 to
baf76ce
Compare
Previously although meant to be per team, the settings were still tied to a specific auth object. This meant that 1 team could have different conflicting settings.
Dschoordsch
force-pushed
the
chore/10685/makeNotificationSettingsPerTeamAndChannel
branch
from
baf76ce to
d14bdc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #10685
Previously although meant to be per team, the settings were still tied to a specific auth object. This meant that 1 team could have different conflicting settings.
This should clean up my mess.
Demo
[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]
Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
Scenario A
Scenario B
Final checklist