-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add client-side RemoveMultipleOrgUsersMutation #10805
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's quite convoluted. From reviewing this I get the impression that removeOrgUser
should be half-broken currently.
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts
Outdated
Show resolved
Hide resolved
Hey @Dschoordsch , thanks so much for taking time to review this. I agree it's quite complicated and it also makes me wonder if
Sounds good? |
@Dschoordsch now with regards to this PR specifically, I have a doubt on this statement you made:
The unsubscribe operation comes with 1 second delay. In my test, the removed users would still get all the updates from the team/org they were removed from? |
Yes, you're right. I wasn't aware of that delay. I also discussed this with Matt. The cleanest solution would be to make the remove object flat with just ids as I had described. While resolving the removed User in this scenario works, it would fail if some User fields were requested where we check additional permissions. The issue is that it's not clear for future developers in this context, that that might happen. So it's safer to make the switch. |
Description
Following up #10675, this PR is the client-side mutation
Final checklist