Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to support input-hidden weights sharing between bi-directional RNNs. #224

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

xinghai-sun
Copy link
Contributor

  1. Add options to enable and disable RNN weights sharing.
  2. Set rnn_layer_size to 2048 by default.
  3. Revert back the striding steps of 1st conv layer from 2 to 3.
  4. Revert Back to BRelu.

Above follows DS2 papers.

@xinghai-sun xinghai-sun requested a review from pkuyym September 4, 2017 10:05
…ional RNNs.

1. Add options to enable and disable RNN weights sharing.
2. Set rnn_layer_size to 2048 by default.
3. Revert back the striding steps of 1st conv layer from 2 to 3.
4. Revert back to BRelu.

Above follows DS2 papers.
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinghai-sun xinghai-sun merged commit 53e59ee into PaddlePaddle:develop Sep 4, 2017
@xinghai-sun xinghai-sun deleted the shared_weight branch September 4, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants