Refine savable

paddlenlp/transformers/configuration_utils.py

@@ -297,7 +297,7 @@
         return ret
 
     @classmethod
-    def _get_nonsavable_keys(cls):
+    def _get_unsavable_keys(cls):
         ret = set()
         for attrs in [
             cls.op_fusion_attributes,
@@ -516,7 +516,7 @@
     _auto_class: Optional[str] = None
 
     # Fix me, it is global for all config
-    _nonsavable_keys = set()
+    _unsavable_keys = set()
 
     def __setattr__(self, key, value):
         if key in super().__getattribute__("attribute_map"):
@@ -542,7 +542,8 @@
         kwargs = attribute_map(self, kwargs=kwargs)
         kwargs.pop("transformers_version", None)
         llm_meta = LlmMetaConfig._get_defaults()
-        self._nonsavable_keys.update(LlmMetaConfig._get_nonsavable_keys())
+        self._unsavable_keys.update(LlmMetaConfig._get_unsavable_keys())
+        self._unsavable_keys.remove("tensor_parallel_degree")
 
         kwargs = set_expected_keys(self, llm_meta, kwargs)
         if self.sequence_parallel:
@@ -1011,14 +1012,14 @@
 
         return serializable_config_dict
 
-    def register_nonsaveable_keys(self, keys):
+    def register_unsavable_keys(self, keys):
         # Save: not save it in any case
         # Print: show it if non defalut value
         if type(keys) == list or type(keys) == tuple:
             for key in keys:
-                self._nonsavable_keys.add(key)
+                self._unsavable_keys.add(key)
         else:
-            self._nonsavable_keys.add(keys)
+            self._unsavable_keys.add(keys)
 
     def to_dict(self, saving_file=False) -> Dict[str, Any]:
         """
@@ -1047,9 +1048,9 @@
             output[key] = value
 
         # Fix for rewrited from_pretrained method, hasattr
-        if saving_file and hasattr(self, "_nonsavable_keys"):
+        if saving_file and hasattr(self, "_unsavable_keys"):
             for key in list(output.keys()):
-                if key in self._nonsavable_keys:
+                if key in self._unsavable_keys:
                     output.pop(key)
 
         if hasattr(self, "quantization_config"):

tests/transformers/test_configuration_utils.py

@@ -96,7 +96,7 @@ def test_model_config_save(self):
 
         config.test_nonsave = "test"
         config.test_nonsave_2 = "test"
-        config.register_nonsaveable_keys(["test_nonsave"])
+        config.register_unsavable_keys(["test_nonsave"])
 
         with tempfile.TemporaryDirectory() as tp:
             config.save_pretrained(tp)
@@ -105,7 +105,7 @@ def test_model_config_save(self):
             loaded_config = json.load(open(os.path.join(tp, "config.json"), "r"))
             assert "fuse_attention_qkv" in loaded_config, "fuse qkv is need to save"
             assert "use_fused_rms_norm" not in loaded_config, "use_fused_rms_norm don't need to save"
-            assert "tensor_parallel_degree" not in loaded_config, "tensor_parallel_degree don't need to save"
+            assert "tensor_parallel_degree" in loaded_config, "tensor_parallel_degree need to save"
             assert "paddlenlp_version" in loaded_config, "always save paddlenlp_version"
             assert (
                 "quantization_config" in loaded_config and "quant_type" in loaded_config["quantization_config"]