Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine doc of pnpair evaluator #5800

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Refine doc of pnpair evaluator #5800

merged 1 commit into from
Nov 21, 2017

Conversation

wanghaoshuang
Copy link
Contributor

fix #5799

@wanghaoshuang wanghaoshuang changed the title Rename info to query_id and add more comments. Refine doc of pnpair evaluator Nov 21, 2017
qingqing01
qingqing01 approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this evalutor is used infrequently, I think we can make the interface standardization and there is no need to consider compatibility. So approve this PR.

@wanghaoshuang wanghaoshuang merged commit 95de6f5 into PaddlePaddle:develop Nov 21, 2017
@wanghaoshuang wanghaoshuang deleted the fix_pnp branch November 21, 2017 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix confused doc of pnpair
2 participants
@wanghaoshuang @qingqing01