-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Mv] move collective/multinode to test dir #51982
Merged
luotao1
merged 11 commits into
PaddlePaddle:develop
from
cattidea:move_collective_multinode_to_test
Mar 28, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b225cad
[Test Mv] move collective/multinode to test dir
Ainavo 20f1fd7
add CMakeList.txt to test/collective
Ainavo 3491581
add bash_test_modules
Ainavo bc1d62f
adjust the order
Ainavo 4c82af9
Merge branch 'develop' into move_collective_multinode_to_test
Ainavo c9f4105
recover bash_test_modules
Ainavo 14e566d
Merge branch 'develop' into move_collective_multinode_to_test
Ainavo fe4ac27
add_subdirectory(collective)
Ainavo 713b9dd
resolve conflicts
Ainavo 30064d5
resolve conflicts
Ainavo 906b2bf
Merge branch 'develop' into move_collective_multinode_to_test
Ainavo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
add_subdirectory(multinode) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python/paddle/fluid/tests/unittests/CMakeLists.txt 下的bash_test_modules能否进行删除?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为 python/paddle/fluid/tests/unittests/CMakeLists.txt 中后续也用到 bash_test_modules 函数,如下图:
在 PR-CI-ROCM-Compile 中也会报错:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,可以留到最后删除python/paddle/fluid/tests目录