Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.31】 Fix Null pointer bug for Case4:paddle.incubate.graph_khop_sampler #51784

Merged
merged 6 commits into from
Mar 21, 2023
Merged

【Hackathon No.31】 Fix Null pointer bug for Case4:paddle.incubate.graph_khop_sampler #51784

merged 6 commits into from
Mar 21, 2023

Conversation

zeroRains
Copy link
Contributor

@zeroRains zeroRains commented Mar 17, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

在调用graph_khop_sampler没有考虑到传入空的tensor进去的情况，所以在执行采样时会出现空指针的情况，现在我加入了检测tensor维度的情况，解决问题。
#49922 (comment)
#49927

@zeroRains zeroRains mentioned this pull request Mar 17, 2023
Closed
@zeroRains
Copy link
Contributor Author

我发现case5也是同一个函数的问题，然后看了一下，问题是相同的，顺便一起修了#49922 (comment)

@paddle-bot paddle-bot bot added the contributor External developers label Mar 17, 2023
wanghuancoder
wanghuancoder approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DesmonDay
DesmonDay approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit c31ffbe into PaddlePaddle:develop Mar 21, 2023
@zeroRains zeroRains deleted the graph_khop_smpler branch March 21, 2023 02:45
@luotao1 luotao1 mentioned this pull request Mar 21, 2023
Closed
@luotao1
Copy link
Contributor

luotao1 commented Mar 21, 2023

hi, @zeroRains

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 /~https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

@luotao1 luotao1 mentioned this pull request Mar 21, 2023
Closed
@zeroRains
Copy link
Contributor Author

这个PR应该可以同时修复 Case 5的问题。#49922 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@DesmonDay DesmonDay DesmonDay approved these changes

Assignees

@luotao1 luotao1

@DesmonDay DesmonDay

@wanghuancoder wanghuancoder

@Ligoml Ligoml

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeroRains @luotao1 @DesmonDay @wanghuancoder @Ligoml