Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_StackOverFlow_case5 #50447

Closed
wants to merge 10 commits into from

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Feb 13, 2023

PR types

Bug fixes

PR changes

OPs

Describe

@paddle-bot
Copy link

paddle-bot bot commented Feb 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 13, 2023
@luotao1 luotao1 mentioned this pull request Feb 14, 2023
veyron95
veyron95 previously approved these changes Feb 17, 2023
Copy link
Contributor

@veyron95 veyron95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测检测到的 ValueError 是其他问题导致的 ValueError,并不是你新增的异常检测代码所抛出的。

@veyron95 veyron95 self-requested a review February 20, 2023 06:28
Comment on lines 545 to 548
def test_countValue_dynamic():
paddle.incubate.graph_reindex(x, x, x, y, y, False)

self.assertRaises(ValueError, test_countValue_dynamic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测检测到的 ValueError 是其他问题导致的 ValueError,并不是你新增的异常检测代码所抛出的。
仅仅保留 546 行再执行单测,就可以看到真正的报错信息

Comment on lines 545 to 546
def test_countValue_dynamic():
paddle.incubate.graph_reindex(x, x, x, y, y, False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在545-546之间打个日志,可以发现 test_countValue_dynamic 方法是不会被执行的。
你可以仅保留 546行,删除545行,来执行单测看看报错信息,报错信息是
image
这个报错信息意思是你的入参错误,y 应该是 tensor,而不是 ndarray

@luotao1
Copy link
Contributor

luotao1 commented Mar 22, 2023

在 develop 上已经无法复现

@luotao1 luotao1 closed this Mar 22, 2023
@enkilee enkilee deleted the fix_StackOverFlow_Case5 branch July 6, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants