-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix_StackOverFlow_case5 #50447
Fix_StackOverFlow_case5 #50447
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单测检测到的 ValueError 是其他问题导致的 ValueError,并不是你新增的异常检测代码所抛出的。
def test_countValue_dynamic(): | ||
paddle.incubate.graph_reindex(x, x, x, y, y, False) | ||
|
||
self.assertRaises(ValueError, test_countValue_dynamic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单测检测到的 ValueError 是其他问题导致的 ValueError,并不是你新增的异常检测代码所抛出的。
仅仅保留 546 行再执行单测,就可以看到真正的报错信息
def test_countValue_dynamic(): | ||
paddle.incubate.graph_reindex(x, x, x, y, y, False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在 develop 上已经无法复现 |
PR types
Bug fixes
PR changes
OPs
Describe
According to Doc. I tried to test the code. And find that when x dim and count dim all equal to 1.
the count value should smaller or equal to 10, otherwise cause error.
if count value larger than 10 . the x dim should larger than 1.