Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix error attributes setting in FusedLinear unitest #50359

Merged
merged 5 commits into from
Mar 6, 2023
Merged

[BugFix] Fix error attributes setting in FusedLinear unitest #50359

merged 5 commits into from
Mar 6, 2023

Conversation

JamesLim-sy
Copy link
Contributor

@JamesLim-sy JamesLim-sy commented Feb 9, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

  • As shown below,

    Paddle/paddle/fluid/operators/fused/fused_gemm_epilogue_op.cc

    Lines 361 to 365 in d3352b9

    AddAttr<std::string>(
    "activation_grad",
    R"DOC((string, default none), The backward activation function. It could be
    one of {none, relu_grad, gelu_grad}. When none is given, The backward Act would
    be null operations)DOC")
    there is no attribute activation but activation_grad in paddle.

@paddle-bot
Copy link

paddle-bot bot commented Feb 9, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Feb 9, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@JamesLim-sy JamesLim-sy closed this Feb 9, 2023
@JamesLim-sy JamesLim-sy changed the title LayerNorm forward Optimization with welford method Remove useless judgment of layernorm_fwd Feb 9, 2023
@JamesLim-sy JamesLim-sy reopened this Feb 9, 2023
@JamesLim-sy JamesLim-sy changed the title Remove useless judgment of layernorm_fwd [BugFix] Fix error attributes setting in FusedLinear unitest Mar 4, 2023
@JamesLim-sy JamesLim-sy reopened this Mar 4, 2023
@JamesLim-sy JamesLim-sy requested a review from mingxu1067 March 4, 2023 16:29
@mingxu1067
Copy link
Collaborator

@JamesLim-sy, thanks for fixing this, LGTM

ZzSean
ZzSean approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesLim-sy JamesLim-sy merged commit 11a6149 into PaddlePaddle:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzSean ZzSean ZzSean approved these changes

@mingxu1067 mingxu1067 Awaiting requested review from mingxu1067

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesLim-sy @mingxu1067 @ZzSean @zhangbopd