fix div 0 error in floormod #49997
Merged
fix div 0 error in floormod #49997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
reviewed
Jan 30, 2023
| @@ -501,6 +501,7 @@ struct MinGradXYFunctor { | |||
| template <typename T, typename Enable = void> | |||
| struct RemainderFunctor { | |||
| inline HOSTDEVICE T operator()(const T a, const T b) const { | |||
| PADDLE_ENFORCE(b != 0, DIV_ERROR_INFO); | |||
There was a problem hiding this comment.
2023-01-22 10:21:48 0. PADDLE_ENFORCE is not recommended. Please use PADDLE_ENFORCE_EQ/NE/GT/GE/LT/LE or PADDLE_ENFORCE_NOT_NULL or PADDLE_ENFORCE_GPU_SUCCESS instead, see [ /~https://github.com/PaddlePaddle/Paddle/wiki/PADDLE_ENFORCE-Rewriting-Specification ] for details.
2023-01-22 10:21:48 You must have one RD (chenwhql (Recommend), luotao1 (Recommend) or lanxianghit) approval for the usage (either add or delete) of PADDLE_ENFORCE.
2023-01-22 10:21:48 PADDLE_ENFORCE(b != 0, DIV_ERROR_INFO);
2023-01-22 10:21:48 1. The error message you wrote in PADDLE_ENFORCE{_**} or PADDLE_THROW does not meet our error message writing specification. Possible errors include 1. the error message is empty / 2. the error message is too short / 3. the error type is not specified. Please read the specification [ /~https://github.com/PaddlePaddle/Paddle/wiki/Paddle-Error-Message-Writing-Specification ], then refine the error message. If it is a mismatch, please request chenwhql (Recommend), luotao1 or lanxianghit review and approve.
2023-01-22 10:21:48 The PADDLE_ENFORCE{_**} or PADDLE_THROW entries that do not meet the specification are as follows:
2023-01-22 10:21:48 PADDLE_ENFORCE(b != 0, DIV_ERROR_INFO);
2023-01-22 10:21:48 There are 2 approved errors.
请修复下Approve流水线的问题
There was a problem hiding this comment.
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
* fix mod 0 error * fix div 0 error in floormod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
related issues
Solution