[Paddle Inference] Memory Optimize destruct argument #49046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangjun
reviewed
Dec 15, 2022
Comment on lines
+1369
to
+1371
| } else { | ||
| argument_.reset(nullptr); | ||
| } |
There was a problem hiding this comment.
这里的释放操作需要确认一下，analysis_argument()主要用于测试，获取fusion_statis字段检测fuse op数量。 需确认这些单测是否有效。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
pass 阶段 argument 会保存网络信息，pass 结束后未析构导致内存增加，推理 pass 阶段完成后，不会再使用 argument ，遂将其变成智能指针手动释放。
修改 analysis 相关单测，删除单测中调用 predictor->analysis_argument() 接口获取 fused 后节点信息。
这样 pass 优化结束后 predictor->analysis_argument() 接口会被释放无法再被调用，目前 analysis_argument（）接口调用多用于调试，mkldnn_int8 会继续调用所以 不在mkldnn下释放。