Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors with gcc-11 #46808

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix build errors with gcc-11 #46808

merged 1 commit into from
Oct 11, 2022
+4 −3

Conversation

lileding
Copy link
Contributor

@lileding lileding commented Oct 9, 2022 •
edited by luotao1
Loading

PR types

Bug fixes

PR changes

Others

Describe

  • Add missing include
  • Fix some iterator type
  • Another block issue is protobuf
    • It fails by a static_assert
    • I currently use host protobuf by define PROTOBUF_ROOT to bypass this issue.

@paddle-bot
Copy link

paddle-bot bot commented Oct 9, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 9, 2022
@paddle-bot
Copy link

paddle-bot bot commented Oct 9, 2022 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@luotao1 luotao1 self-assigned this Oct 10, 2022
@luotao1
Copy link
Contributor

luotao1 commented Oct 10, 2022

感谢您的贡献，目前PR-CI-Codestyle-Check 流水线失败

  • 可以直接根据提示进行修改
2022-10-09 15:58:22  #pragma once
2022-10-09 15:58:22  
2022-10-09 15:58:22 -#include <cstdint>
2022-10-09 15:58:22  #include <cstddef>
2022-10-09 15:58:22 +#include <cstdint>
2022-10-09 15:58:22  #include <unordered_map>
  • 后续可以安装下precommit工具进行自动格式化，见文档
➜  pip install pre-commit==2.17.0
➜  pre-commit install

@SigureMo 可以考虑在流水线报错里加入使用precommit的命令和文档链接，便于大家用工具自动化。

@SigureMo
Copy link
Member

SigureMo commented Oct 10, 2022 •
edited
Loading

@SigureMo 可以考虑在流水线报错里加入使用precommit的命令和文档链接，便于大家用工具自动化。

好的，我先加到 TODOs 里，之后做一下

@SigureMo SigureMo mentioned this pull request Oct 10, 2022
Closed
@lileding
Fix build on gcc-11
05ef0d1 
  * Add missing <cstddef>
  * Fix some iterator type
  * Currently use host protobuf to bypass build failure
@jzhang533
Copy link
Contributor

Compatible with gcc11 is great!

BTW: if you met the issue of "undefined symbol: _dl_sym, version GLIBC_PRIVATE" when running paddle, this has been solved by #45351. related issue: #36801.

luotao1
luotao1 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 28ef0ff into PaddlePaddle:develop Oct 11, 2022
@luotao1
Copy link
Contributor

luotao1 commented Oct 18, 2022

好的，我先加到 TODOs 里，之后做一下

@SigureMo 可以考虑提高下优先级么，又碰到外部开发者挂在这上面了。#46644 (comment)

@SigureMo
Copy link
Member

@SigureMo 可以考虑提高下优先级么，又碰到外部开发者挂在这上面了。#46644 (comment)

好的我这两天做一下，因为 docs 那边也有个类似问题（PaddlePaddle/docs#5338 (comment) ），会考虑一起做一下

@SigureMo SigureMo mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lileding @CLAassistant @luotao1 @SigureMo @jzhang533