-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] Move mean op kernel into phi #40872
[Phi] Move mean op kernel into phi #40872
Conversation
} | ||
|
||
} // namespace phi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是不是加个alias命名准确些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个算子的Kernel逻辑需要迁移过来吗,是不是可以调用reduce_mean的Kernel进行复用?
试了下,不行,无法复用reduce_mean,reduce_mean并不能简单支持bf16,底层function不支持,而且这个PR两天冲突了两次,还有修改完善在这个算子上进行 |
PR types
Function optimization
PR changes
OPs
Describe
[Phi] Move mean op kernel into phi
原先的mean op现在不能被reduce_mean等价替换,调用频次高达800余次,出于兼容考虑,单独迁移过来