[WIP] partial disabling of caching for conv2d, conv_transpose, quantize and pool2d #36595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pool2d partially stripped of caching
|
Thanks for your contribution! |
wozna
reviewed
Oct 28, 2021
| mkldnn::convolution_backward_data, | ||
| mkldnn::convolution_backward_weights>( | ||
| mkldnn_engine, ctx.GetPlace()), | ||
| is_test_(false) { |
There was a problem hiding this comment.
Shouldn't there be a check for the is_test attribute as it is done for forward is_test_(ctx.Attr<bool>("is_test"))? Then we also check if is_test is false, which if we set false here, it doesn't make sense
|
depracated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Disables some more caching of oneDNN objects in order to fix #34554