-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Code Coverage for Paddle refactor code #3489
Conversation
go/pserver/optimizer.go
Outdated
@@ -15,7 +15,7 @@ | |||
package pserver | |||
|
|||
// #cgo CFLAGS: -I ../../ | |||
// #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm | |||
// #cgo LDFLAGS: /Users/liaogang/baidu/Paddle/go/pserver/client/c/libpaddle_go_optimizer.a -lstdc++ -lm -g -O0 -fprofile-arcs -ftest-coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ignore this modification, because go/pserver/.gitignore
is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use git rm PATH_TO_FILE
to remove it from git.
Changes Unknown when pulling 539c86b on gangliao:coveralls into ** on PaddlePaddle:develop**. |
Changes Unknown when pulling 8ceee0f on gangliao:coveralls into ** on PaddlePaddle:develop**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except optimizer.go
should be removed from git.
@@ -15,7 +15,7 @@ | |||
package pserver | |||
|
|||
// #cgo CFLAGS: -I ../../ | |||
// #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming optimizer.go
to optimizer.go.in
will break building from Go without cmake. Do we really need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can find another way to suppress this later.
Since you haven't replied for a long time, we have closed this issue/pr. |
fix #3298
https://coveralls.io/github/PaddlePaddle/Paddle