Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old demo catalog #2353

Closed
wants to merge 1 commit into from
Closed

remove old demo catalog #2353

wants to merge 1 commit into from

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jun 2, 2017 •
edited
Loading

solve #2350

@lcy-seso
Copy link
Contributor

lcy-seso commented Jun 5, 2017 •
edited
Loading

demos 目录下一部分包含在 PaddleBook里。

  • 已包含在Book里，这部分直接删掉，基本没有损失

    • introduction
    • mnist
    • recommendation
    • sentiment
    • word2vec
    • image_classification
    • semantic_role_labeling
    • seqToseq

  • 以下几个例子直接删掉，是否合适？

    • gan
    • model_zoo
    • sequence_tagging
    • quick_start
    • traffic_prediction

lcy-seso
lcy-seso requested changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 demos not included in PaddleBook, is it OK to directly remove them? Shall we make a plan to upgrade these examples into the v2 version, and before the upgrade is finished, do not remove demos not included in PaddleBook?

@wangkuiyi
Copy link
Collaborator

How about we rename the directory into v1_api_demo and leave those V1-API based examples there?

@luotao1
Copy link
Contributor Author

luotao1 commented Jun 5, 2017

I will pull a new request to follow the comments.

@luotao1 luotao1 closed this Jun 5, 2017
@luotao1 luotao1 deleted the demo branch June 5, 2017 03:52
@luotao1 luotao1 mentioned this pull request Jun 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcy-seso lcy-seso lcy-seso requested changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@helinwang helinwang Awaiting requested review from helinwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luotao1 @lcy-seso @wangkuiyi