softmax cross entropy support high rank #16798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
test=develop
… softmax_cross_support_high_rank
chengduoZH
reviewed
Apr 15, 2019
| if ((!ctx->IsRuntime()) && (framework::product(logits_dims) <= 0 || | ||
| framework::product(labels_dims) <= 0)) { | ||
| check = false; | ||
| } |
There was a problem hiding this comment.
bool check = ctx->IsRuntime() || (framework::product(logits_dims) > 0 && framework::product(labels_dims) > 0);
| auto loss_dims = logits_dims; | ||
| loss_dims[rank - 1] = 1; | ||
| ctx->SetOutputDim("Loss", loss_dims); | ||
| // ctx->SetOutputDim("Loss", {logits_dims[0], 1}); |
There was a problem hiding this comment.
line 142 should be removed.
|
No more comments |
… softmax_cross_support_high_rank
… softmax_cross_support_high_rank
kuke
approved these changes
Apr 16, 2019
phlrain
added a commit
to phlrain/Paddle
that referenced
this pull request
Apr 16, 2019
…ort_high_rank softmax cross entropy support high rank
phlrain
added a commit
that referenced
this pull request
Apr 17, 2019
Merge pull request #16798 from phlrain/softmax_cross_support_high_rank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
softmax cross entopy support high rank