Calculation - DATEDIF - fix result for Y & YM units #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for negative results and too small results 2000-02-02 => 2001-02-01 > DATEDIF with Y unit: 0 year (returned -1 before fix) > DATEDIF with YM unit: 11 months (returned -1 before fix)
albanduval
changed the title
|
Thank you for this submission. The original code was ported from the older PHPExcel library, with it's PHP 5.2 minimal version, so using DateInterval was never an option, and the code wasn't perfect. Now, with PHPSpreadsheet's higher minimum version, it is an option; so thank you for working on this update, and for resolving the issues that were in the original code. Your work is appreciated. |
PowerKiKi
added a commit
that referenced
this pull request
May 31, 2020
### Added - Support writing to streams in all writers [#1292](#1292) - Support CSV files with data wrapping a lot of lines [#1468](#1468) - Support protection of worksheet by a specific hash algorithm [#1485](#1485) ### Fixed - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [#1448](#1448) - Fix return type in docblock for the Cells::get() [#1398](#1398) - Fix RATE, PRICE, XIRR, and XNPV Functions [#1456](#1456) - Save Excel 2010+ functions properly in XLSX [#1461](#1461) - Several improvements in HTML writer [#1464](#1464) - Fix incorrect behaviour when saving XLSX file with drawings [#1462](#1462), - Fix Crash while trying setting a cell the value "123456\n" [#1476](#1481) - Improved DATEDIF() function and reduced errors for Y and YM units [#1466](#1466) - Stricter typing for mergeCells [#1494](#1494) ### Changed - Drop support for PHP 7.1, according to https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support - Drop partial migration tool in favor of complete migration via RectorPHP [#1445](#1445) - Limit composer package to `src/` [#1424](#1424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
To solve the issue #1465
Attached is a zip file containing :
The results show differences in the results for both Y & YM units, correcting the detected wrong results.