Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IF implementation to comply with Excel behavior #1165

Closed

Conversation

frantzmiccoli
Copy link
Contributor

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

IF implementation compliant with Excel behavior:

=IF(NA(), 'whatever1', 'whatever2')

was not returning #N/A. Now it does.

@rolandsusans
Copy link
Contributor

rolandsusans commented Sep 23, 2019

Nice catch, checked the result of this example - IF function on my excel
=IF(NA(),1,0) returns NA().
This fix LGTM !

@frantzmiccoli
Copy link
Contributor Author

Now uses Functions::isError as suggested by @MarkBaker on #1167

@PowerKiKi PowerKiKi closed this in 445cc18 Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants