Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non static PHPUnit assert #1884

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Use non static PHPUnit assert #1884

merged 7 commits into from
Nov 26, 2024

Conversation

MrYamous
Copy link
Collaborator

Fixes #1883

@MrYamous
Copy link
Collaborator Author

CI fails seems unrelated to changes

tests/Rule/UseNonStaticAssertionsTest.php Outdated Show resolved Hide resolved
tests/Rule/UseNonStaticAssertionsTest.php Outdated Show resolved Hide resolved
src/Rule/UseNonStaticAssertions.php Outdated Show resolved Hide resolved
docs/rules.md Outdated Show resolved Hide resolved
src/Rule/UseNonStaticAssertions.php Outdated Show resolved Hide resolved
@OskarStark OskarStark changed the title [Rule] Use non static assert Use non static PHPUnit assert Nov 24, 2024
@MrYamous
Copy link
Collaborator Author

I'm struggling with tests in PhpCodeBlocks only, can one of you take a look please ?

@OskarStark OskarStark merged commit 97374df into OskarStark:develop Nov 26, 2024
6 of 8 checks passed
@OskarStark
Copy link
Owner

Many thank @MrYamous

OskarStark added a commit that referenced this pull request Nov 26, 2024
* develop: (59 commits)
  Use non static PHPUnit assert (#1884)
  composer(deps-dev): bump ergebnis/php-cs-fixer-config from 6.37.0 to 6.39.0 (#1888)
  composer(deps-dev): bump symfony/var-dumper from 7.1.7 to 7.1.8 (#1882)
  composer(deps): bump symfony/console from 7.1.7 to 7.1.8 (#1881)
  composer(deps): bump symfony/dependency-injection from 7.1.6 to 7.1.8 (#1880)
  composer(deps): bump symfony/string from 7.1.6 to 7.1.8 (#1879)
  composer(deps-dev): bump maglnet/composer-require-checker from 4.13.0 to 4.14.0 (#1878)
  composer(deps-dev): bump rector/rector from 1.2.9 to 1.2.10 (#1877)
  composer(deps-dev): bump phpstan/phpstan from 1.12.7 to 1.12.8 (#1876)
  composer(deps-dev): bump symfony/var-dumper from 7.1.6 to 7.1.7 (#1874)
  composer(deps): bump symfony/console from 7.1.6 to 7.1.7 (#1873)
  composer(deps): bump symfony/config from 7.1.6 to 7.1.7 (#1872)
  composer(deps-dev): bump rector/rector from 1.2.8 to 1.2.9 (#1871)
  composer(deps): bump symfony/finder from 7.1.4 to 7.1.6 (#1870)
  composer(deps): bump symfony/yaml from 7.1.5 to 7.1.6 (#1869)
  composer(deps): bump symfony/options-resolver from 7.1.1 to 7.1.6 (#1867)
  composer(deps-dev): bump symfony/var-dumper from 7.1.5 to 7.1.6 (#1866)
  composer(deps): bump symfony/config from 7.1.1 to 7.1.6 (#1865)
  composer(deps): bump symfony/console from 7.1.5 to 7.1.6 (#1864)
  composer(deps): bump symfony/dependency-injection from 7.1.5 to 7.1.6 (#1863)
  ...
@MrYamous
Copy link
Collaborator Author

Oh I didn't see your commit, I've just finished correcting
Thanks @OskarStark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$this->assert* over self::assert*
3 participants