-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto for XML parsing. #1910
Refacto for XML parsing. #1910
Conversation
967ed2c
to
d414d88
Compare
/accept |
🕗 /accept is running, please wait for completion. |
Previously, the parser was rather raw: we processed the buffer bytes by bytes, checking if the buffer was a valid XML file. Now, we use libxml SAX parser to detect the end of the XML.
🔨 Auto rebase from |
🕗 /accept is running, please wait for completion. |
d414d88
to
f82ed05
Compare
❌ Some checks are still failing, please fix them before trying to merge this pull request. |
/accept |
🕗 /accept is running, please wait for completion. |
✅ Pull request merged and closed by
|
Previously, the parser was rather raw: we processed the buffer byte by byte, checking if the buffer was a valid XML file at every byte. Now, we use libxml SAX parser to detect the end of the XML.
The performance has been improved. Example: iterating 100 times with a ~600 lines XML body
Before:
After: