Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto for XML parsing. #1910

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Refacto for XML parsing. #1910

merged 1 commit into from
Sep 12, 2023

Conversation

jcamiel
Copy link
Collaborator

@jcamiel jcamiel commented Sep 9, 2023

Previously, the parser was rather raw: we processed the buffer byte by byte, checking if the buffer was a valid XML file at every byte. Now, we use libxml SAX parser to detect the end of the XML.

The performance has been improved. Example: iterating 100 times with a ~600 lines XML body

Before:

$ time loop --iter 100 hurlfmt integration/tests_ok/post_xml.hurl > /dev/null
6.41s user 0.13s system 99% cpu 6.570 total

After:

$ time loop --iter 100 hurlfmt integration/tests_ok/post_xml.hurl > /dev/null
0.80s user 0.13s system 97% cpu 0.955 total

@jcamiel jcamiel marked this pull request as ready for review September 12, 2023 12:13
@fabricereix
Copy link
Collaborator

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

Previously, the parser was rather raw: we processed the buffer bytes by bytes, checking if the buffer was a valid XML file.
Now, we use libxml SAX parser to detect the end of the XML.
@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, Orange-OpenSource/hurl/refacto-xml-parser now embeds these commits:

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@fabricereix
Copy link
Collaborator

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by fabricereix with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/refacto-xml-parser branch into Orange-OpenSource/hurl/master branch:

@hurl-bot hurl-bot merged commit f82ed05 into master Sep 12, 2023
@hurl-bot hurl-bot deleted the refacto-xml-parser branch September 12, 2023 13:38
@jcamiel jcamiel mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants