This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Cassie 4.0 #246
Merged
Cassie 4.0 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscetbon
force-pushed
the
cassie4
branch
2 times, most recently
from
88fd787 to
b27794b
Compare
Comment on lines
-104
to
-122
| func TestGetNumTokensPerRacks_2DC(t *testing.T) { | ||
| assert := assert.New(t) | ||
|
|
||
| cc := helperInitCluster(t, "cassandracluster-2DC.yaml") | ||
|
|
||
| numTokens := cc.NumTokensPerRacks("online-rack1") | ||
| assert.Equal(int32(200), numTokens) | ||
|
|
||
| numTokens = cc.NumTokensPerRacks("online-rack2") | ||
| assert.Equal(int32(200), numTokens) | ||
|
|
||
| numTokens = cc.NumTokensPerRacks("stats-rack1") | ||
| assert.Equal(int32(32), numTokens) | ||
|
|
||
| numTokens = cc.NumTokensPerRacks("toto-toto") | ||
| assert.Equal(int32(256), numTokens) | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Since the numToken is now directly in Cassandra's config, there is no way / point to test it through this test ? That's why its only a delete and not a refactor ?
website/docs/3_configuration_deployment/5_cassandra_configuration.md
Outdated
Show resolved
Hide resolved
PERES-Richard
previously approved these changes
May 26, 2021
…ion.md Co-authored-by: PERES-Richard <43060465+PERES-Richard@users.noreply.github.com>
PERES-Richard
previously approved these changes
May 28, 2021
PERES-Richard
approved these changes
May 31, 2021
This was referenced Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support Cassandra 4.0. In order to do that the first step was to use datastax/cass-config-builder to generate configuration in order to be able to choose between Cassandra 3.11 and 4.0.
A few PRs/issues were created datastax/cass-config-definitions#20, datastax/cass-config-definitions#23 and datastax/cass-config-definitions#22
A new docker image of Cassandra 4.0 has been created as none was available and it's been updated to 4.0-rc1 See /~https://github.com/docker-library/cassandra/tree/master/4.0.
The Configmap is not supposed to have any other files than pre_run.sh and post_run.sh. Also the configuration is now embedded in the CassandraCluster.Spec object and/or in the Topology at DCs/Racks levels.
Integration tests were ran with that new version, see /~https://github.com/cscetbon/cass-operator-casskop-compat/actions/runs/854966176