Add SES to send emails from web-backend #59
Merged
+161
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikkoKauhanen
force-pushed
the
feat/SES
branch
2 times, most recently
from
c680b5e to
454bee8
Compare
MikkoKauhanen
changed the title
MikkoKauhanen
force-pushed
the
feat/SES
branch
5 times, most recently
from
4d08486 to
0dfaff0
Compare
hsalokor
approved these changes
Jan 17, 2025
| if (parseInt(process.env.SEND_EMAIL, 10)) { | ||
| const info: Record<string, unknown> = await transporter.sendMail(mailOptions); | ||
| winstonLogger.debug('System email notification delivery completed: ' + info); | ||
| if (parseInt(process.env.SEND_SYSTEM_NOTIFICATION_EMAIL, 10)) { |
There was a problem hiding this comment.
Lisäisin tähän eksplisiittisen tarkistuksen luettavuuden vuoksi, tyyliin:
if (parseInt(process.env.SEND_SYSTEM_NOTIFICATION_EMAIL, 10) === 1) {
There was a problem hiding this comment.
isEnabled funktio tehty joka tarkistaa onko env x arvo === '1'
| if (!(process.env.SEND_EMAIL === '1')) { | ||
| winstonLogger.debug('Email sending disabled'); | ||
| const emails = materials.filter((m) => m.email != undefined).map((m) => m.email); | ||
| if (!(process.env.SEND_EXPIRATION_NOTIFICATION_EMAIL === '1')) { |
There was a problem hiding this comment.
Sama kommentti liittyen eksplisiittiseen tarkistukseen
| @@ -84,8 +111,8 @@ export async function sendRatingNotificationMail() { | |||
| holder[d.email] = d.materialname; | |||
| } | |||
| }); | |||
| if (!(process.env.SEND_EMAIL === '1')) { | |||
| winstonLogger.debug('Email sending disabled'); | |||
| if (!(process.env.SEND_RATING_NOTIFICATION === '1')) { | |||
There was a problem hiding this comment.
Eksplisiittinen vertailu myös tähän
There was a problem hiding this comment.
isEnabled funktio tehty joka tarkistaa onko env x arvo === '1'
| winstonLogger.debug('Message sent: %s', info.messageId); | ||
| const content = await verificationEmailText(url); | ||
|
|
||
| if (process.env.SEND_VERIFICATION_EMAIL === '1') { |
There was a problem hiding this comment.
Tässä on sitten hieman eri tarkistus, joka on ok, mutta checkit voisi ehkä irrottaa apufunktioksi joka palauttaa boolean-arvon
There was a problem hiding this comment.
isEnabled funktio tehty joka tarkistaa onko env x arvo === '1'
MikkoKauhanen
force-pushed
the
feat/SES
branch
3 times, most recently
from
628019a to
f65c012
Compare
MikkoKauhanen
changed the title
MikkoKauhanen
force-pushed
the
feat/SES
branch
from
99d1b41 to
d228ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces AWS SES to dev and QA environments with domain identity.
aoe-web-backend mailService has been changed to use AWS SDK V2 SES to send emails instead of node mailer.
After deployment the SES is in sandbox mode which means that only to verified emails aoe can send an email. For production we need to request production access once the SES is deployed.