-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/streaming app #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyvältä näyttää, pois lukien nuo kosmeettiset
aoe-infra/infra/bin/infra.ts
Outdated
@@ -24,6 +24,8 @@ import { BastionStack } from '../lib/bastion-stack'; | |||
import { SecretManagerStack } from '../lib/secrets-manager-stack' | |||
import { OpenSearchServerlessStack } from "../lib/opensearch-stack"; | |||
import { HostedZoneStack } from '../lib/hosted-zone-stack' | |||
import {S3Stack} from "../lib/s3Stack"; | |||
import {PolicyStatement} from "aws-cdk-lib/aws-iam"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sulla on näiden sisennysasetuksissa jotain outoa, itsellä korjailee editori nämä tuohon välilyöntiversioon
aoe-infra/infra/lib/S3Stack.ts
Outdated
import * as s3 from 'aws-cdk-lib/aws-s3' | ||
import { BucketAccessControl, ObjectOwnership } from 'aws-cdk-lib/aws-s3' | ||
import { Construct } from 'constructs' | ||
import {StackProps} from "aws-cdk-lib"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sama sisennysjuttu
aoe-infra/infra/lib/ecs-service.ts
Outdated
@@ -38,6 +38,9 @@ interface EcsServiceStackProps extends StackProps { | |||
healthCheckInterval: number | |||
healthCheckTimeout: number | |||
securityGroup: ISecurityGroup | |||
secrets?: secretsmanager.Secret[] | |||
iAmPolicyStatement?: iam.PolicyStatement | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roikkuva tyhjä rivi
@@ -25,6 +25,8 @@ export class SecurityGroupStack extends cdk.Stack { | |||
public readonly dataAnalyticsServiceSecurityGroup: ec2.SecurityGroup; | |||
public readonly webBackendsServiceSecurityGroup: ec2.SecurityGroup; | |||
|
|||
public readonly streamingServiceSecurityGroup: ec2.SecurityGroup; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roikkuva tyhjä rivi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok ok, mergaan
* Add S3Stack and streaming service ecs task
This PR introduces ace-streaming-app-ecs task and s3stack