Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/streaming app #23

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Feat/streaming app #23

merged 5 commits into from
Nov 29, 2024

Conversation

MikkoKauhanen
Copy link
Contributor

This PR introduces ace-streaming-app-ecs task and s3stack

@MikkoKauhanen MikkoKauhanen changed the base branch from main to aws-migration November 29, 2024 11:40
Copy link
Contributor

@hsalokor hsalokor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyvältä näyttää, pois lukien nuo kosmeettiset

@@ -24,6 +24,8 @@ import { BastionStack } from '../lib/bastion-stack';
import { SecretManagerStack } from '../lib/secrets-manager-stack'
import { OpenSearchServerlessStack } from "../lib/opensearch-stack";
import { HostedZoneStack } from '../lib/hosted-zone-stack'
import {S3Stack} from "../lib/s3Stack";
import {PolicyStatement} from "aws-cdk-lib/aws-iam";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sulla on näiden sisennysasetuksissa jotain outoa, itsellä korjailee editori nämä tuohon välilyöntiversioon

import * as s3 from 'aws-cdk-lib/aws-s3'
import { BucketAccessControl, ObjectOwnership } from 'aws-cdk-lib/aws-s3'
import { Construct } from 'constructs'
import {StackProps} from "aws-cdk-lib";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sama sisennysjuttu

@@ -38,6 +38,9 @@ interface EcsServiceStackProps extends StackProps {
healthCheckInterval: number
healthCheckTimeout: number
securityGroup: ISecurityGroup
secrets?: secretsmanager.Secret[]
iAmPolicyStatement?: iam.PolicyStatement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roikkuva tyhjä rivi

@@ -25,6 +25,8 @@ export class SecurityGroupStack extends cdk.Stack {
public readonly dataAnalyticsServiceSecurityGroup: ec2.SecurityGroup;
public readonly webBackendsServiceSecurityGroup: ec2.SecurityGroup;

public readonly streamingServiceSecurityGroup: ec2.SecurityGroup;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roikkuva tyhjä rivi

Copy link
Contributor

@hsalokor hsalokor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ok, mergaan

@MikkoKauhanen MikkoKauhanen merged commit 65e1649 into aws-migration Nov 29, 2024
3 checks passed
@MikkoKauhanen MikkoKauhanen deleted the feat/streaming-app branch December 5, 2024 08:27
ehakala pushed a commit that referenced this pull request Dec 11, 2024
* Add S3Stack and streaming service ecs task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants