Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image_data comment on pixel order #684

Conversation

thomassedlmayer
Copy link
Contributor

@thomassedlmayer thomassedlmayer commented Nov 4, 2022

Description

We noticed that the pixel order of the image_data field in CameraSensorView was not specified by CameraSensorViewConfiguration as the description of image_data says:

The raw image data in the memory layout and order specified by the camera sensor input configuration.

Since both radar and lidar reflections are currently defined to be ordered left-to-right, top-to-bottom (see following quote), it could be the case that this was accidently omitted for image_data. (RadarSensorView, LidarSensorView)

This field includes one entry for each ray, in left-to-right, top-to-bottom order (think of scan lines in a TV).

Therefore, the default pixel order should probably align with the definitions of radar and lider reflections. If further pixel orders are desired a enum could be added to CameraSensorViewConfiguration but I think this small change would already clarify enough to be able to reliably exchange image data with OSI.

This change can be seen as a bug fix. The description of image_data that a pixel order can be specified in CameraSensorViewConfiguration is definitely misleading.

Checklist

#### References
#681

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
@thomassedlmayer thomassedlmayer added the SensorModeling The Group in the ASAM development project working on sensor modeling topics. label Nov 4, 2022
@thomassedlmayer thomassedlmayer added this to the V3.6.0 milestone Nov 4, 2022
@thomassedlmayer thomassedlmayer requested review from pmai and raue November 4, 2022 10:47
@jdsika jdsika added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 4, 2022
@pmai pmai removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 7, 2022
@pmai
Copy link
Contributor

pmai commented Nov 7, 2022

CCB 2022-11-07: Still to be discussed in sensor group, hence postponed at CCB.

@jdsika
Copy link
Contributor

jdsika commented Mar 3, 2023

replaced by #698

@jdsika jdsika closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SensorModeling The Group in the ASAM development project working on sensor modeling topics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants