Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: fix projection endpoint #9956

Merged
merged 1 commit into from
Dec 10, 2024
Merged

editoast: fix projection endpoint #9956

merged 1 commit into from
Dec 10, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Dec 5, 2024 •
edited
Loading

close #9534

We found out that this code was broken since the trains variable does not have the same length as trains_details and cached_projections.

@flomonster flomonster requested a review from a team as a code owner December 5, 2024 10:16
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 5, 2024
@flomonster flomonster requested a review from woshilapin December 5, 2024 10:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (9c34c10) to head (fa44028).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/train_schedule/projection.rs 96.29% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9956      +/-   ##
==========================================
+ Coverage   79.88%   80.10%   +0.21%     
==========================================
  Files        1048     1048              
  Lines      105245   105253       +8     
  Branches      756      756              
==========================================
+ Hits        84078    84315     +237     
+ Misses      21126    20897     -229     
  Partials       41       41
Flag Coverage Δ
editoast 74.22% <97.82%> (+0.75%) ⬆️
front 89.36% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi requested review from a team as code owners December 8, 2024 15:07
@github-actions github-actions bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:front Work on Standard OSRD Interface modules labels Dec 8, 2024
@github-actions github-actions bot removed area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:front Work on Standard OSRD Interface modules labels Dec 8, 2024
@younesschrifi younesschrifi force-pushed the fam/fix-projection branch 4 times, most recently from 9063f07 to 2b71ebe Compare December 9, 2024 14:07
@younesschrifi younesschrifi requested review from woshilapin and removed request for younesschrifi December 9, 2024 14:07
@flomonster flomonster removed request for a team December 9, 2024 16:07
flomonster
flomonster commented Dec 9, 2024
View reviewed changes
editoast/src/views/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/train_schedule.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the fam/fix-projection branch 2 times, most recently from 445c2c3 to 03b5e0e Compare December 9, 2024 16:40
@flomonster @younesschrifi
editoast: fix projection endpoint
fa44028 
Co-authored-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
woshilapin
woshilapin approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. The improvements look good.

@younesschrifi younesschrifi added this pull request to the merge queue Dec 10, 2024
Merged via the queue into dev with commit 512f065 Dec 10, 2024
27 checks passed
@younesschrifi younesschrifi deleted the fam/fix-projection branch December 10, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path projection endpoint fails
4 participants
@flomonster @codecov-commenter @woshilapin @younesschrifi