front: use Date instead of string in OsrdConfState.startTime #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/compute-op-schedules-date
branch
from
d0a78a8 to
590695a
Compare
clarani
reviewed
Dec 6, 2024
RomainValls
approved these changes
Dec 6, 2024
|
Ooops, sounds like export const formatLocalDateTime = (date: Date) =>
- dayjs(date).local().format('YYYY-MM-DDTHH:MM:SS');
+ dayjs(date).local().format('YYYY-MM-DDTHH:mm:ss'); |
emersion
force-pushed
the
emr/compute-op-schedules-date
branch
from
590695a to
dc40969
Compare
emersion
force-pushed
the
emr/compute-op-schedules-date
branch
from
dc40969 to
5b07ebf
Compare
Improves type safety. While at it, fix a small typo: s/substractTo/subtractFrom/ Signed-off-by: Simon Ser <contact@emersion.fr>
Improves type safety. Signed-off-by: Simon Ser <contact@emersion.fr>
Improves type safety. Previously, it was important for OsrdConfState.startTime to be in a specific timezone, because the string was later truncated and directly used on an datetime-local form input. This patch improves robustness by converting to the local timezone right before feeding the value to the datetime-local form input, making it so a different timezone in OsrdConfState.startTime doesn't break the app. IsoDateTimeString is not longer used and can be dropped. Signed-off-by: Simon Ser <contact@emersion.fr>
startTime should be used instead, because it's an already-parsed Date object instead of a string. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/compute-op-schedules-date
branch
from
5b07ebf to
252b871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Improves type safety.