core: reduce the amount of logs for repeated events #9755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
requested review from
Erashin and
bougue-pe
and removed request for
Erashin
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9755 +/- ##
==========================================
- Coverage 37.88% 37.87% -0.02%
==========================================
Files 992 992
Lines 90965 90965
Branches 1176 1176
==========================================
- Hits 34463 34452 -11
- Misses 56048 56059 +11
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Erashin
approved these changes
Nov 18, 2024
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/RequirementsParser.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/RequirementsParser.kt
Outdated
Show resolved
Hide resolved
bougue-pe
approved these changes
Nov 19, 2024
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMSimulations.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMSimulations.kt
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/reduce-core-logging
branch
from
b246cc1 to
fd06dab
Compare
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com> core: stdcm: only log failed simulations once Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com> Update core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMSimulations.kt Co-authored-by: bougue-pe <150040524+bougue-pe@users.noreply.github.com> Update core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMSimulations.kt Co-authored-by: bougue-pe <150040524+bougue-pe@users.noreply.github.com>
eckter
force-pushed
the
ech/reduce-core-logging
branch
from
fd06dab to
bde028f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the amount of logs in two cases: