Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grant and revoke role to group using CLI #9622

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested a review from a team as a code owner November 7, 2024 10:38
@flomonster flomonster requested a review from leovalais November 7, 2024 10:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 42.48%. Comparing base (b777099) to head (ee8a74d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/client/roles.rs 0.00% 23 Missing ⚠️
editoast/src/models/auth.rs 0.00% 6 Missing ⚠️
editoast/editoast_authz/src/authorizer.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9622      +/-   ##
============================================
- Coverage     42.50%   42.48%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105569   105588      +19     
  Branches       3304     3304              
============================================
- Hits          44868    44863       -5     
- Misses        58748    58772      +24     
  Partials       1953     1953              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.66% <0.00%> (-0.07%) ⬇️
front 18.79% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed groups exist 🤦 Thanks for the fix!

@flomonster flomonster enabled auto-merge November 7, 2024 15:34
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
@flomonster flomonster force-pushed the fam/fix-grant-remove-role branch from dd8d24e to ee8a74d Compare November 8, 2024 16:17
@flomonster flomonster added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit f05eecf Nov 8, 2024
25 checks passed
@flomonster flomonster deleted the fam/fix-grant-remove-role branch November 8, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants