Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: bump osrd-ui to use the new manchette props #9507

Merged
merged 2 commits into from
Nov 18, 2024
Merged

front: bump osrd-ui to use the new manchette props #9507

merged 2 commits into from
Nov 18, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 29, 2024

closes #9506

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes missing coverage. Please review.

Project coverage is 41.80%. Comparing base (6600f73) to head (3477114).
Report is 40 commits behind head on dev.

Files with missing lines Patch % Lines
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 84 Missing ⚠️
...ations/stdcm/utils/formatStdcmIntoSpaceTimeData.ts 0.00% 4 Missing and 1 partial ⚠️
...ationalStudies/helpers/upsertNewProjectedTrains.ts 0.00% 3 Missing ⚠️
...dules/simulationResult/components/TrainDetails.tsx 0.00% 3 Missing ⚠️
...ications/stdcm/hooks/useProjectedTrainsForStdcm.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #9507      +/-   ##
============================================
- Coverage     42.48%   41.80%   -0.68%     
  Complexity     2272     2272              
============================================
  Files          1312     1281      -31     
  Lines        105608   104079    -1529     
  Branches       3305     3305              
============================================
- Hits          44869    43512    -1357     
+ Misses        58786    58614     -172     
  Partials       1953     1953
Flag Coverage Δ
core 74.95% <ø> (ø)
editoast 73.63% <ø> (-0.05%) ⬇️
front 18.79% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator ?
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion emersion force-pushed the cni/9506-bump-osrd-ui branch from 0180871 to d65379f Compare November 12, 2024 13:13
@emersion emersion self-assigned this Nov 12, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 12, 2024
@emersion emersion force-pushed the cni/9506-bump-osrd-ui branch from d65379f to 2ed8c4b Compare November 12, 2024 13:16
@clarani
front: bump osrd-ui to use the new manchette props
991b329 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: bump osrd-ui to 53
3477114 
- speed-space-chart
- ui-core
- ui-icons

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/9506-bump-osrd-ui branch from 2ed8c4b to 3477114 Compare November 14, 2024 10:51
@clarani clarani marked this pull request as ready for review November 14, 2024 10:51
@clarani clarani requested a review from a team as a code owner November 14, 2024 10:51
@clarani clarani requested review from Yohh and SharglutDev November 14, 2024 10:51
@emersion emersion removed their assignment Nov 14, 2024
@emersion
Copy link
Member

Note, these two commits should be squashed together because the app won't build in-between.

SharglutDev
SharglutDev reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Everything works great. Just left a few comments/suggestions

...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx Show resolved Hide resolved
front/src/applications/stdcm/utils/formatStdcmIntoSpaceTimeData.ts Show resolved Hide resolved
@clarani
Copy link
Contributor Author

clarani commented Nov 18, 2024

@emersion why do you think we should squash the 2 commits ? I can build after the 1st commit (without the 2nd one) in local

@emersion
Copy link
Member

Hm, right… The first commit bumps half of osrd-ui and the other bumps the rest. I guess that's fine.

@clarani clarani added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit 08a1080 Nov 18, 2024
27 checks passed
@clarani clarani deleted the cni/9506-bump-osrd-ui branch November 18, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Yohh Yohh Awaiting requested review from Yohh

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: bump osrd-ui to 53
4 participants
@clarani @codecov-commenter @emersion @SharglutDev