-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: sim: ignore overlapping scheduled points #7747
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7747 +/- ##
============================================
- Coverage 28.62% 28.61% -0.01%
Complexity 2038 2038
============================================
Files 1244 1244
Lines 153687 153671 -16
Branches 3012 3014 +2
============================================
- Hits 43991 43976 -15
+ Misses 107905 107902 -3
- Partials 1791 1793 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Show resolved
Hide resolved
4b033f9
to
74a6de6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK to merge as-is, but I would make that warning as rare as possible with an early dedup on consecutive identical steps (probably with an info/debug log) to ease the monitoring and separate "legitimate" cases (weird input) from the suspect ones (internal core behavior).
Context: As discussed, this case from the issue is not about consecutive identical step, as they are separated by another separate step on the same block but not at the same place.
So here, the pathfinding is wrongly aggregating identical steps because intermediate ones are on the same block (to be adressed in #7761)
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Outdated
Show resolved
Hide resolved
496dfb2
to
a85eb96
Compare
I've added a simple check to dedup the scheduled items, but I've only merged the ones that are entirely identical (offset, time, stop duration, on stop signal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt
Outdated
Show resolved
Hide resolved
Update core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt Co-authored-by: bougue-pe <150040524+bougue-pe@users.noreply.github.com>
a85eb96
to
45e3f52
Compare
Fix #7744