Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor scenario V2 tests #7668

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jun 7, 2024

part of #6980

@Wadjetz Wadjetz self-assigned this Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 95.19231% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (4b360d4) to head (0b1b79f).

Files Patch % Lines
editoast/src/views/v2/scenario.rs 90.19% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7668      +/-   ##
============================================
+ Coverage     28.45%   28.47%   +0.01%     
  Complexity     2038     2038              
============================================
  Files          1243     1243              
  Lines        153286   153344      +58     
  Branches       3008     3008              
============================================
+ Hits          43622    43668      +46     
- Misses       107873   107885      +12     
  Partials       1791     1791              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 71.89% <95.19%> (+0.01%) ⬆️
front 9.83% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-scenario-v2 branch from 7bf770a to 0b1b79f Compare June 7, 2024 11:32
@Wadjetz Wadjetz requested review from woshilapin and leovalais June 7, 2024 11:34
@Wadjetz Wadjetz marked this pull request as ready for review June 7, 2024 12:01
@Wadjetz Wadjetz requested a review from a team as a code owner June 7, 2024 12:01
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@Wadjetz Wadjetz added this pull request to the merge queue Jun 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Jun 7, 2024
Merged via the queue into dev with commit 06e1e8f Jun 7, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-refactor-scenario-v2 branch June 7, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants