Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pfn/front/adapt simulation results v2 #7485

Merged
merged 1 commit into from
May 31, 2024
Merged

Pfn/front/adapt simulation results v2 #7485

merged 1 commit into from
May 31, 2024

Conversation

SharglutDev
Copy link
Contributor

close #7484

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.86580% with 4349 lines in your changes are missing coverage. Please review.

Project coverage is 28.47%. Comparing base (3203aa3) to head (26bea78).

Files Patch % Lines
...lationResult/components/SimulationResultsMapV2.tsx 0.00% 387 Missing and 1 partial ⚠️
...ult/components/SpaceTimeChart/SpaceTimeChartV2.tsx 0.00% 351 Missing and 1 partial ⚠️
...t/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx 0.00% 332 Missing and 1 partial ⚠️
...mponents/SpaceCurvesSlopes/SpaceCurvesSlopesV2.tsx 0.00% 274 Missing and 1 partial ⚠️
...schedule/components/DriverTrainScheduleV2/utils.ts 0.00% 270 Missing and 1 partial ⚠️
...s/DriverTrainScheduleV2/exportDriverScheduleCSV.ts 0.00% 244 Missing and 1 partial ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 237 Missing and 1 partial ⚠️
...t/components/ChartHelpers/drawElectricalProfile.ts 0.00% 234 Missing ⚠️
...tionResult/components/SpeedSpaceChart/d3Helpers.ts 0.00% 210 Missing ⚠️
front/src/applications/operationalStudies/hooks.ts 0.00% 202 Missing and 1 partial ⚠️
... and 45 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7485      +/-   ##
============================================
- Coverage     29.06%   28.47%   -0.60%     
  Complexity     2028     2028              
============================================
  Files          1225     1241      +16     
  Lines        149222   153121    +3899     
  Branches       2962     3000      +38     
============================================
+ Hits          43375    43601     +226     
- Misses       104097   107732    +3635     
- Partials       1750     1788      +38
Flag Coverage Δ
core 75.12% <ø> (ø)
editoast 71.91% <ø> (-0.05%) ⬇️
front 9.84% <5.86%> (-0.15%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/adapt-simulation-resultsV2 branch 9 times, most recently from 1b5a102 to 0229e4b Compare May 30, 2024 15:48
clarani
clarani requested changes May 30, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/utils.ts Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/utils.ts Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/utils.ts Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/utils.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/drawCurve.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/drawHelpers.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/drawPowerRestriction.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/utils.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/utils.ts Outdated Show resolved Hide resolved
clarani
clarani reviewed May 31, 2024
View reviewed changes
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SimulationResultsMapV2.tsx Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpaceCurvesSlopes/utils.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpaceCurvesSlopes/utils.ts Show resolved Hide resolved
front/src/modules/simulationResult/components/SpaceCurvesSlopes/SpaceCurvesSlopesV2.tsx Outdated Show resolved Hide resolved
clarani
clarani reviewed May 31, 2024
View reviewed changes
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceSettingsV2.tsx Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/consts.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/prepareData.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/prepareData.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/types.ts Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/types.ts Show resolved Hide resolved
front/src/modules/simulationResult/components/TimeButtonsV2.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/DriverTrainSchedule/DriverTrainScheduleHelpers.ts Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/DriverTrainScheduleV2/driverTrainScheduleV2ExportCSV.ts Outdated Show resolved Hide resolved
clarani
clarani reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@SharglutDev SharglutDev marked this pull request as ready for review May 31, 2024 20:10
@SharglutDev SharglutDev requested a review from a team as a code owner May 31, 2024 20:10
clarani
clarani reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're almost good !

@SharglutDev SharglutDev force-pushed the pfn/front/adapt-simulation-resultsV2 branch from b8baf63 to 26bea78 Compare May 31, 2024 21:04
clarani
clarani approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SharglutDev SharglutDev added this pull request to the merge queue May 31, 2024
Merged via the queue into dev with commit 625d185 May 31, 2024
17 checks passed
@SharglutDev SharglutDev deleted the pfn/front/adapt-simulation-resultsV2 branch May 31, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: adapt simulation results v2
3 participants
@SharglutDev @codecov-commenter @clarani